Roy Golan has posted comments on this change.

Change subject: core: Inject Task schedulers instead of JNDI lookups
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/41035/4/backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java
File 
backend/manager/modules/scheduler/src/main/java/org/ovirt/engine/core/utils/timer/DBSchedulerUtilQuartzImpl.java:

Line 86:      * @return a {@code DBSchedulerUtilQuartzImpl} instance
Line 87:      */
Line 88:     @Deprecated
Line 89:     public static SchedulerUtil getInstance() {
Line 90:         return instance;
> If it is intermediate state only then there is no problem.
removed it completely in the next patchset
Line 91:     }
Line 92: 
Line 93:     /**
Line 94:      * To avoid data serialization issues for jobdata that is 
persisted in the database inputParams should be of


-- 
To view, visit https://gerrit.ovirt.org/41035
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2288d0bd0584c7ba17f3dabaff268e40cbdddbea
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to