Roy Golan has posted comments on this change. Change subject: core: Make DwhHeartBeat a BackendService and a CDI bean ......................................................................
Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/41038/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/dwh/DwhHeartBeat.java: Line 43: @OnTimerMethodAnnotation(DWH_HEART_BEAT_METHOD) Line 44: public void engineIsRunningNotification() { Line 45: try { Line 46: heartBeatVar.setDateTime(new Date()); Line 47: DbFacade.getInstance().getDwhHistoryTimekeepingDao().save(heartBeatVar); > Can DAO also be injected? I'm not sure about current status of injecting ob indeed Line 48: } catch (Exception ex) { Line 49: log.error("Error updating DWH Heart Beat: {}", ex.getMessage()); Line 50: log.debug("Exception", ex); Line 51: } -- To view, visit https://gerrit.ovirt.org/41038 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53589a48f302d6b3711afa144b666a1e1694406e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
