Martin Peřina has posted comments on this change. Change subject: core: fix non-responding logging in case of no PM ......................................................................
Patch Set 6: (2 comments) https://gerrit.ovirt.org/#/c/36397/6/backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties File backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties: Line 665: VDS_ALERT_FENCE_OPERATION_SKIPPED_BROKEN_CONNECTIVITY=Host ${VdsName} became non responsive and was not restarted due to Fencing Policy: ${Percents} percents of the Hosts in the Cluster have connectivity issues. Line 666: VDS_ALERT_NOT_RESTARTED_DUE_TO_POLICY=Host ${VdsName} became non responsive and was not restarted due to the Cluster Fencing Policy. Line 667: VDS_ALERT_FENCE_DISABLED_BY_CLUSTER_POLICY=Host ${VdsName} became Non Responsive and was not restarted due to disabled fencing in the Cluster Fencing Policy. Line 668: VDS_HOST_NOT_RESPONDING_CONNECTING=Host ${VdsName} is not responding. It will stay in Connecting state for a grace period of ${Seconds} seconds and after that an attempt to fence the host will be issued. Line 669: VDS_HOST_NOT_RESPONDING=Host ${VdsName} is not responding. I would add here a warning that PM is disabled: Host ${VdsName} is not responding. Host cannot be fenced automatically, because power management for the host is disabled. Line 670: TASK_STOPPING_ASYNC_TASK=Stopping async task ${CommandName} that started at ${Date} Line 671: REFRESH_REPOSITORY_IMAGE_LIST_FAILED=Refresh image list failed for domain(s): ${imageDomains}. Please check domain activity. Line 672: REFRESH_REPOSITORY_IMAGE_LIST_SUCCEEDED=Refresh image list succeeded for domain(s): ${imageDomains} Line 673: REFRESH_REPOSITORY_IMAGE_LIST_INCOMPLETE=Refresh image list probably incomplete for domain ${imageDomain}, only ${imageListSize} images discovered. https://gerrit.ovirt.org/#/c/36397/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java: Line 788: AuditLogType auditLogType; Line 789: log.warn("Host '{}' is not responding. It will stay in Connecting state for a grace period " + Line 790: "of {} seconds and after that an attempt to fence the host will be issued.", Line 791: cachedVds.getName(), Line 792: TimeUnit.MILLISECONDS.toSeconds(timeoutToFence)); Please remove this log, it's a part of the if below Line 793: Line 794: if (cachedVds.isPmEnabled()) { Line 795: msg = "Host '{}' is not responding. It will stay in Connecting state for a grace period " + Line 796: "of {} seconds and after that an attempt to fence the host will be issued."; -- To view, visit https://gerrit.ovirt.org/36397 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1f7e7a9987be93023309c0b25f35d856d2ec1f04 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
