Francesco Romani has posted comments on this change. Change subject: core, engine: servlet to support the console proxy ......................................................................
Patch Set 27: (5 comments) https://gerrit.ovirt.org/#/c/35887/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllUserProfilesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllUserProfilesQuery.java: Line 10: super(parameters); Line 11: } Line 12: Line 13: @Override Line 14: protected void executeQueryCommand() { > since this query return information from the backend without any restrictio Done Line 15: getQueryReturnValue().setReturnValue( Line 16: DbFacade.getInstance().getUserProfileDao().getAll()); Line 17: } https://gerrit.ovirt.org/#/c/35887/27/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForAnotherUserQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsForAnotherUserQuery.java: Line 19: protected void executeQueryCommand() { Line 20: List<VM> vmsList = getDbFacade().getVmDao().getAllForUser(getParameters().getId()); Line 21: Line 22: getQueryReturnValue().setReturnValue(vmsList); Line 23: } > i think currently using the isInternal hack is ok, documented Done https://gerrit.ovirt.org/#/c/35887/27/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java: Line 8: GetVmByVmId(VdcQueryAuthType.User), Line 9: GetVmByVmNameForDataCenter(VdcQueryAuthType.User), Line 10: GetAllVms(VdcQueryAuthType.User), Line 11: GetAllVmsForUser(VdcQueryAuthType.User), Line 12: GetAllVmsForAnotherUser(VdcQueryAuthType.User), > now im pretty sure this should not be user query, also the one below Done Line 13: GetUnregisteredVms, Line 14: GetUnregisteredVmTemplates, Line 15: GetVmsRunningOnOrMigratingToVds, Line 16: GetVmsByStorageDomain, Line 177: GetDbUserByUserNameAndDomain(VdcQueryAuthType.User), Line 178: GetUserBySessionId(VdcQueryAuthType.User), Line 179: GetEngineSessionIdToken(VdcQueryAuthType.User), Line 180: GetUserProfile(VdcQueryAuthType.User), Line 181: GetAllUserProfiles(VdcQueryAuthType.User), > noted, same as above as my answer changed as above. Line 182: Line 183: // Directory queries: Line 184: GetDirectoryUserById(VdcQueryAuthType.User), Line 185: GetDirectoryGroupById(VdcQueryAuthType.User), https://gerrit.ovirt.org/#/c/35887/27/backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java File backend/manager/modules/services/src/main/java/org/ovirt/engine/core/services/VMConsoleProxyServlet.java: Line 67: jsonUser.put("entity", "ssh-key"); Line 68: if (user != null) { Line 69: jsonUser.put("username", user.getLoginName()); Line 70: } Line 71: jsonUser.put("key", profile.getSshPublicKey()); > afair. this can contain multiple ssh key, its ok to return like this, or ne I'm not sure. The consumer of the data seem to assume one key per user (or meybe each key should be bond to a different entity-id)? For 3.6 we will have only one key per user, so I believe it is fair to keep it that way. Will make sure this is forward-compatible, however. Line 72: Line 73: jsonUsers.add(jsonUser); Line 74: } Line 75: } -- To view, visit https://gerrit.ovirt.org/35887 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53c721da21cefcf4069d14c7016b6f7d97f9eac9 Gerrit-PatchSet: 27 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vdel...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
