Oved Ourfali has posted comments on this change. Change subject: core[BLL]: Adding external status to command ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40995/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddExternalEventCommand.java: Line 81: List<PermissionSubject> permissionList = getPermissionList(getParameters().getEvent()); Line 82: List<PermissionSubject> joinedPermissionList = new ArrayList<>(); Line 83: joinedPermissionList.addAll(hostExtStatusUpdatePermissionsList); Line 84: joinedPermissionList.addAll(permissionList); Line 85: return joinedPermissionList; I'd do: List<PermissionSubject> permissionList = getPermissionList(getParameters().getEvent()); if (hasHostExternalStatus()) { permissionList.add(new PermissionSubject(new Guid(getParameters().getEvent().getVdsId().toString()), VdcObjectType.VDS, ActionGroup.EDIT_HOST_CONFIGURATION)); } return permissionList; Line 86: } Line 87: Line 88: private boolean hasHostExternalStatus() { Line 89: return getParameters().getEvent().getVdsId() != null && getParameters().getExternalStatus() != null; -- To view, visit https://gerrit.ovirt.org/40995 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I271aa3f841a3820482d89a1675e28dcb75540277 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
