Ori Liel has posted comments on this change. Change subject: core, restapi: Support adding permission using role name ......................................................................
Patch Set 3: (1 comment) All ok, I have one question (see my comment in AddPermissionCommand.java) https://gerrit.ovirt.org/#/c/40694/3/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java: Line 58: perm You're filling fields in 'perm' which were not filled before. Should this be a part of this patch? Are these fields used later? -- To view, visit https://gerrit.ovirt.org/40694 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I74f22e9bebbc102a45b76e9c62cc44961edadfbc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
