Alon Bar-Lev has posted comments on this change. Change subject: aaa: Modify welcome screen to show user name and options as menu ......................................................................
Patch Set 16: (2 comments) missing welcome addition to spec to enforce ssl https://gerrit.ovirt.org/#/c/40672/16/backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml File backend/manager/modules/welcome/src/main/webapp/WEB-INF/web.xml: Line 147 Line 148 Line 149 Line 150 Line 151 missing the ssl stuff, please copy from sso web.xml, both session config and constraints https://gerrit.ovirt.org/#/c/40672/16/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: Line 258: Line 259: # Line 260: # Error page Line 261: # Line 262: ERROR_PAGE=${ENGINE_URI}/error.html should probably moved to previous patch Line 263: Line 264: # Line 265: # SSO Configuration Line 266: # -- To view, visit https://gerrit.ovirt.org/40672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0227778d53f4c63867aa2887580539efab8fa7c8 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
