Allon Mureinik has posted comments on this change.
Change subject: core: report VDS if lun is not available
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
minor comment, see inline
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
Line 80: for (String lunId : getParameters().getLunIds()) {
Line 81: LUNs lun = lunsMap.get(lunId);
Line 82: if (lun == null) {
Line 83: //fail
Line 84:
((ConnectAllHostsToLunCommandReturnValue)getReturnValue()).setFailedVds(spmVds);
Not a big fan of having the same cast 4 times - why not override the return
type of getReturnValue()
Line 85: ((ConnectAllHostsToLunCommandReturnValue)
getReturnValue()).setFailedLun(getDbFacade().getLunDao()
Line 86: .get(lunId));
Line 87: return;
Line 88: }
--
To view, visit http://gerrit.ovirt.org/8603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I30a87e57b0121bfb2a4da9b38c3032604b245bc9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Ayal Baron <aba...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
