[Engine-patches] Change in ovirt-engine[master]: core: using qos from db if exist.

[alkaplan]

Alona Kaplan has posted comments on this change.

Change subject: core: using qos from db if exist.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/40958/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java
File 
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HostSetupNetworksVDSCommand.java:

Line 74:                 
attributes.put(VdsProperties.NETWORK_CUSTOM_PROPERTIES, 
attachment.getProperties());
Line 75:             }
Line 76: 
Line 77:             if (getParameters().getHostNetworkQosSupported()) {
Line 78:                 NetworkQosMapper qosMapper =
Shouldn't you use HostNetworkQosMapper?
Line 79:                         new NetworkQosMapper(attributes,
Line 80:                                 VdsProperties.HOST_QOS_INBOUND,
Line 81:                                 VdsProperties.HOST_QOS_OUTBOUND);
Line 82: 


Line 79:                         new NetworkQosMapper(attributes,
Line 80:                                 VdsProperties.HOST_QOS_INBOUND,
Line 81:                                 VdsProperties.HOST_QOS_OUTBOUND);
Line 82: 
Line 83:                 Guid qosId = attachment.getNetwork().getQosId();
What about qos overridden by the nic?

Please take a look at the old implementation 
(SetupNetworksVDSCommand.generateNetworks())-
if (hostNetworkQosSupported && NetworkUtils.qosConfiguredOnInterface(iface, 
network)) {
                HostNetworkQosMapper qosMapper = new HostNetworkQosMapper(opts);
                qosMapper.serialize(iface.isQosOverridden() ? iface.getQos() : 
qosDao.get(network.getQosId()));
}
Line 84:                 qosMapper.serialize(qosId == null ? new NetworkQoS() : 
networkQoSDao.get(qosId));
Line 85:             }
Line 86: 
Line 87:             networks.put(attachment.getNetworkName(), attributes);


-- 
To view, visit https://gerrit.ovirt.org/40958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4e27dbae78698a9aca33ef97db64c001c1a8c301
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Mucha <mmu...@redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches