Greg Sheremeta has posted comments on this change. Change subject: webadming,engine : Refactored SizeUnit as per IEC binary prefixes ......................................................................
Patch Set 6: Code-Review+2 (4 comments) a few trivial nitpicks. good patch. https://gerrit.ovirt.org/#/c/40810/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-05-11 11:45:49 +0530 Line 4: Commit: anmolbabu <anb...@redhat.com> Line 5: CommitDate: 2015-05-15 06:43:18 -0400 Line 6: Line 7: webadming,engine : Refactored SizeUnit as per IEC binary prefixes fix typo -- s/webadming/webadmin/ Line 8: Line 9: This patch does the following: Line 10: [1] Adds a AlternateMessage to dynamically form size string(size+unit) Line 11: which in most places previously, used to do a normal string concat https://gerrit.ovirt.org/#/c/40810/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/CreateBrickPopupView.java: Line 101: @Ignore Line 102: Label messageLabel; Line 103: Line 104: private final static ApplicationConstants constants = AssetProvider.getConstants(); Line 105: private static final UIMessages messages = ConstantsManager.getInstance().getMessages(); s/static final/final static/ (match the above line) Line 106: Line 107: private final Driver driver = GWT.create(Driver.class); Line 108: Line 109: @Inject https://gerrit.ovirt.org/#/c/40810/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VolumeCapacityRenderer.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VolumeCapacityRenderer.java: Line 11: import com.google.gwt.text.shared.AbstractRenderer; Line 12: Line 13: public class VolumeCapacityRenderer<T extends Number> extends AbstractRenderer<T> { Line 14: Line 15: private static final UIMessages MESSAGES = ConstantsManager.getInstance().getMessages(); change to "private static final UIMessages messages" (keep consistent) Line 16: private final CommonApplicationConstants constants; Line 17: Line 18: public VolumeCapacityRenderer(CommonApplicationConstants constants) { Line 19: this.constants = constants; https://gerrit.ovirt.org/#/c/40810/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/GlusterCapacityCell.java: Line 24: UIMessages change to "private static final UIMessages messages" (keep consistent) -- To view, visit https://gerrit.ovirt.org/40810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieacb29c0df8d5355a754a3db15f976a986d771fd Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
