Martin Mucha has posted comments on this change. Change subject: engine: Add NetworkAttachmentsValidator ......................................................................
Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/34968/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/NetworkAttachmentsValidator.java: Line 15: import org.ovirt.engine.core.compat.Guid; Line 16: import org.ovirt.engine.core.utils.NetworkUtils; Line 17: Line 18: /** Line 19: * The {@code NetworkAttachmentsValidator} is performs validation on the entire network attachments as a whole and for > s/is performs/performs Done Line 20: * cross network attachments configuration. For a specific network attachment entity validation use Line 21: * {@link org.ovirt.engine.core.bll.validator.NetworkAttachmentValidator}; Line 22: */ Line 23: public class NetworkAttachmentsValidator { Line 73: return true; Line 74: } Line 75: Line 76: HashBag networkTypes = new HashBag(networksOnIface); Line 77: if (networkTypes.contains(NetworkType.VM) && networkTypes.size() > 1 > networkTypes.size() > 1 is redundant, you won't get here if networkTypes.si Done Line 78: || networkTypes.contains(NetworkType.NON_VM) && networkTypes.getCount(NetworkType.NON_VM) > 1) { Line 79: return false; Line 80: } Line 81: -- To view, visit https://gerrit.ovirt.org/34968 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92771cc35560ff4101231c3c7a40e6becbe3e8f2 Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Alona Kaplan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
