Shubhendu Tripathi has posted comments on this change. Change subject: gluster: Add rhs version if available ......................................................................
Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/40361/2//COMMIT_MSG Commit Message: Line 5: CommitDate: 2015-05-14 15:53:36 +0530 Line 6: Line 7: gluster: Add rhs version if available Line 8: Line 9: Currently engine shows only glusterfs version. Correct the spelling mistakes Line 10: This patch addes seperate field for rhs version in the Line 11: table and reterives rhs version from vdsm if availabe Line 12: and displays in the engine ui Line 13: https://gerrit.ovirt.org/#/c/40361/2/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java: Line 235: Remove blank spaces https://gerrit.ovirt.org/#/c/40361/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/host/SubTabHostGeneralSoftwareView.java: Line 85: formBuilder.addFormItem(new FormItem(constants.kvmVersionHostGeneral(), kvmVersion, 0, virtSupported).withAutoPlacement()); Line 86: formBuilder.addFormItem(new FormItem(constants.libvirtVersionHostGeneral(), libvirtVersion, 0, virtSupported).withAutoPlacement()); Line 87: formBuilder.addFormItem(new FormItem(constants.vdsmVersionHostGeneral(), vdsmVersion, 0).withAutoPlacement()); Line 88: formBuilder.addFormItem(new FormItem(constants.spiceVersionHostGeneral(), spiceVersion, 0, virtSupported).withAutoPlacement()); Line 89: formBuilder.addFormItem(new FormItem(constants.glusterVersionHostGeneral(), glusterVersion, 0, glusterSupported).withAutoPlacement()); Looks like this field is added always. What happens if rhs-version is not available ? Line 90: formBuilder.addFormItem(new FormItem(constants.rhsVersionHostGeneral(), rhsVersion, 0, glusterSupported).withAutoPlacement()); Line 91: } Line 92: Line 93: @Override -- To view, visit https://gerrit.ovirt.org/40361 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I395877a528e7cac7ff4c526a200c64b7c808167d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Timothy Asir <tjeya...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
