Ramesh N has posted comments on this change. Change subject: webadmin: add additional features support in cluster popup. ......................................................................
Patch Set 11: (4 comments) https://gerrit.ovirt.org/#/c/39757/11/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java: Line 925: Line 926: setEnableOvirtService(new EntityModel<Boolean>()); Line 927: setEnableGlusterService(new EntityModel<Boolean>()); Line 928: setAdditionalClusterFeatures(new ListModel<List<AdditionalFeature>>()); Line 929: ArrayList<List<AdditionalFeature>> newList = new ArrayList<List<AdditionalFeature>>(); > - Only List<List<... Done Line 930: newList.add(Collections.<AdditionalFeature> emptyList()); Line 931: getAdditionalClusterFeatures().setItems(newList, null); Line 932: setSpiceProxyEnabled(new EntityModel<Boolean>()); Line 933: getSpiceProxyEnabled().setEntity(false); Line 1703: // > please handle progress with startProgress and stopProgress like the initTun Done https://gerrit.ovirt.org/#/c/39757/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.java: Line 795: Line 796: @Override Line 797: public void eventRaised(Event<? extends EventArgs> ev, Object sender, EventArgs args) { Line 798: List<List<AdditionalFeature>> items = (List<List<AdditionalFeature>>) object.getAdditionalClusterFeatures().getItems(); Line 799: // Hind the fields if there is no feature to show > :%s/hind/hide Done Line 800: additionalFeaturesExpander.setVisible(!items.get(0).isEmpty()); Line 801: additionalFeaturesExpanderContent.setVisible(!items.get(0).isEmpty()); Line 802: } Line 803: }); https://gerrit.ovirt.org/#/c/39757/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterPopupView.ui.xml: Line 195: <ge:StringEntityModelPasswordBoxEditor ui:field="glusterHostPasswordEditor" /> Line 196: <g:Label ui:field="messageLabel" addStyleNames="{style.messageLabel}" /> Line 197: <ge:EntityModelCheckBoxEditor ui:field="enableOptionalReasonEditor" /> Line 198: <ge:EntityModelCheckBoxEditor ui:field="enableHostMaintenanceReasonEditor" /> Line 199: <d:AdvancedParametersExpander ui:field="expander"/> > this does not seem to be used Oops. That was a miss from Trial and Error. Line 200: <g:FlowPanel> Line 201: <g:Label ui:field="rngLabel" addStyleNames="{style.panelTitle}" /> Line 202: <ge:EntityModelCheckBoxEditor ui:field="rngRandomSourceRequired" /> Line 203: <ge:EntityModelCheckBoxEditor ui:field="rngHwrngSourceRequired" /> -- To view, visit https://gerrit.ovirt.org/39757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic13dda67f3e9a7d7134030c3923470291c3c5aec Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
