Hello Einav Cohen, I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/40947 to review the following change. Change subject: webadmin, userportal: unnecessary quotation marks ...................................................................... webadmin, userportal: unnecessary quotation marks Removed unnecessary double quotation marks from a couple of strings. Change-Id: I6bcfffcfa041b3eec05d09a0e4c04fbbdeb04bd4 Signed-off-by: Einav Cohen <eco...@redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/47/40947/1 diff --git a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties index 6ab21ac..6657bde 100644 --- a/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties +++ b/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties @@ -379,7 +379,7 @@ VAR__ACTION__FORCE_SELECT=$action force select VAR__ACTION__EXTEND_IMAGE_SIZE=$action extend VAR__ACTION__UPDATE_VM_VERSION=$action update version for -VAR__ACTION__VOLUME_SNAPSHOT_CONFIG_UPDATE="$action gluster volume snapshot config update" +VAR__ACTION__VOLUME_SNAPSHOT_CONFIG_UPDATE=$action gluster volume snapshot config update VAR__HOST_STATUS__UP=$hostStatus Up VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL=$hostStatus Up, Maintenance or Non operational @@ -833,7 +833,7 @@ VALIDATION.DISK_IMAGE.DESCRIPTION.INVALID=Snapshot description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. VALIDATION.DISK_IMAGE.DESCRIPTION.NOT_EMPTY=Snapshot description cannot be empty VALIDATION_DISK_IMAGE_DESCRIPTION_MAX=Snapshot description must not exceed 4000 characters -VALIDATION.DATA_CENTER.DESCRIPTION.INVALID="Data Center description must be formed of ASCII charis only" +VALIDATION.DATA_CENTER.DESCRIPTION.INVALID=Data Center description must be formed of ASCII charis only VALIDATION.DATA_CENTER.NAME.INVALID=Data Center name must be formed of alphanumeric characters, numbers or "-_" VALIDATION_ID_NULL=ID is required. VALIDATION_NAME_NULL=Name is required. diff --git a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties index 55dfd79..c0d0299 100644 --- a/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties +++ b/frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties @@ -783,7 +783,7 @@ VALIDATION_DISK_IMAGE_DESCRIPTION_NOT_INVALID=Snapshot description must be formed only from alpha-numeric characters and special characters that conform to the standard ASCII character set. VALIDATION_DISK_IMAGE_DESCRIPTION_NOT_EMPTY=Snapshot description cannot be empty VALIDATION_DISK_IMAGE_DESCRIPTION_MAX=Snapshot description must not exceed 4000 characters -VALIDATION_DATA_CENTER_DESCRIPTION_INVALID="Data Center description must be formed of ASCII charis only" +VALIDATION_DATA_CENTER_DESCRIPTION_INVALID=Data Center description must be formed of ASCII charis only VALIDATION_DATA_CENTER_NAME_INVALID=Data Center name must be formed of "a-z0-9A-Z" or "-_" VALIDATION_ID_NULL=ID is required. VALIDATION_NAME_NULL=Name is required. diff --git a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties index 62deed7..3bbfd4c 100644 --- a/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties +++ b/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties @@ -382,7 +382,7 @@ VAR__ACTION__FORCE_SELECT=$action force select VAR__ACTION__EXTEND_IMAGE_SIZE=$action extend VAR__ACTION__UPDATE_VM_VERSION=$action update version for -VAR__ACTION__VOLUME_SNAPSHOT_CONFIG_UPDATE="$action gluster volume snapshot config update" +VAR__ACTION__VOLUME_SNAPSHOT_CONFIG_UPDATE=$action gluster volume snapshot config update VAR__HOST_STATUS__UP=$hostStatus Up VAR__HOST_STATUS__UP_MAINTENANCE_OR_NON_OPERATIONAL=$hostStatus Up, Maintenance or Non operational @@ -828,7 +828,7 @@ VALIDATION_STORAGE_DOMAIN_NAME_INVALID=Storage Domain name must be formed of "a-z0-9A-Z" or "-_" VALIDATION.STORAGE_DOMAIN.DESCRIPTION.INVALID=Storage Domain description must be formed of "a-z0-9A-Z" or "-_" VALIDATION.STORAGE_DOMAIN.DESCRIPTION.MAX=Storage Domain description must not exceed 4000 characters -VALIDATION_DATA_CENTER_DESCRIPTION_INVALID="Data Center description must be formed of ASCII charis only" +VALIDATION_DATA_CENTER_DESCRIPTION_INVALID=Data Center description must be formed of ASCII charis only VALIDATION_DATA_CENTER_NAME_INVALID=Data Center name must be formed of "a-z0-9A-Z" or "-_" VALIDATION_ID_NULL=ID is required. VALIDATION_NAME_NULL=Name is required. -- To view, visit https://gerrit.ovirt.org/40947 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6bcfffcfa041b3eec05d09a0e4c04fbbdeb04bd4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5-gluster Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches