Ramesh N has posted comments on this change.

Change subject: gluster: enable new gluster features using new feature check
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40921/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/GlusterFeaturesUtil.java:

Line 19:     public static boolean isGlusterForceAddBricksSupported(Version 
version) {
Line 20:         return Version.v3_3.compareTo(version) <= 0;
Line 21:     }
Line 22: 
Line 23:     public static boolean isGlusterBrickProvisioningSupported(Version 
version) {
> How other features like geo-rep and snapshot are taken care ??
May be we can send another patch to disable geo-rep and snapshot in clusters 
less than 3.5 compatibility.
Line 24:         return Version.v3_5.compareTo(version) <= 0;
Line 25:     }


-- 
To view, visit https://gerrit.ovirt.org/40921
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9074a500caa1b5a30cea19e9fa4420e12d3fa6a1
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to