Moti Asayag has uploaded a new change for review.
Change subject: engine: Avoid use of AuditLogDaoMocker when log director mocked
......................................................................
engine: Avoid use of AuditLogDaoMocker when log director mocked
Since the AuditLogDirector can be mocked, there is no real need
to use AuditLogDaoMocker.
Change-Id: I88437e09fd935c9258488bff97c378685cbc4368
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M
backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
1 file changed, 0 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/42/40942/1
diff --git
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
index 8a88677..39af3f0 100644
---
a/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
+++
b/backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VmsMonitoringTest.java
@@ -26,7 +26,6 @@
import org.ovirt.engine.core.compat.Version;
import org.ovirt.engine.core.dal.dbbroker.DbFacade;
import org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector;
-import org.ovirt.engine.core.dao.AuditLogDAO;
import org.ovirt.engine.core.dao.DiskDao;
import org.ovirt.engine.core.dao.VdsDAO;
import org.ovirt.engine.core.dao.VdsGroupDAO;
@@ -97,8 +96,6 @@
@Mock
private VdsDAO vdsDao;
- AuditLogDAO mockAuditLogDao = new AuditLogDaoMocker();
-
VM vm_1_db;
VM vm_1_vdsm;
@@ -143,7 +140,6 @@
private void initConditions() {
when(dbFacade.getVdsGroupDao()).thenReturn(groupDAO);
when(dbFacade.getVmDao()).thenReturn(vmDAO);
- when(dbFacade.getAuditLogDao()).thenReturn(mockAuditLogDao);
when(dbFacade.getVmDeviceDao()).thenReturn(vmDeviceDAO);
when(dbFacade.getVmDynamicDao()).thenReturn(vmDynamicDao);
when(dbFacade.getDiskDao()).thenReturn(diskDAO);
--
To view, visit https://gerrit.ovirt.org/40942
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88437e09fd935c9258488bff97c378685cbc4368
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
