Michael Pasternak has posted comments on this change.

Change subject: <restapi>:  RESTAPI: RSDL does not document '?current' query 
parameter in: PUT /api/vms/xxx/cdroms/yyy
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
Line 240:       - mandatoryArguments: {}
Line 241:         optionalArguments: {cdrom.file.id: 'xs:string'}
Line 242:     urlparams:
Line 243:       async: {context: matrix, type: 'xs:boolean', value: true|false, 
required: false}
Line 244:       current: {context: matrix, type: 'xs:boolean', value: 
true|false, required: false}
current not matrix parameter, but query:

current: {context: query, type: 'xs:boolean', value: true|false, required: 
false}
Line 245:     headers:
Line 246:       Content-Type: {value: application/xml|json, required: true}
Line 247:       Correlation-Id: {value: 'any string', required: false}
Line 248: - name: /api/vms/{vm:id}/cdroms|rel=add


--
To view, visit http://gerrit.ovirt.org/8572
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie320d59dadab22d5330198ce7ca17d371b51e82a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to