Arik Hadas has posted comments on this change. Change subject: core: Save RNG device when VM is running ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40132/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java: Line 275: } Line 276: } Line 277: Line 278: return null; Line 279: } can we move it to VmDeviceCommonUtils instead? Line 280: Line 281: private boolean isVmDeviceExists(Map<Guid, VmDevice> vmManagedDeviceMap, String name) { Line 282: return findVmDeviceByName(vmManagedDeviceMap, name) != null; Line 283: } -- To view, visit https://gerrit.ovirt.org/40132 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9aa41b0cacd77120b002123d8e196e215e20fdc Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Shmuel Leib Melamud <smela...@redhat.com> Gerrit-Reviewer: Shmuel Melamud <smela...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
