Ramesh N has posted comments on this change. Change subject: engine: add feature comptability check for VDS ......................................................................
Patch Set 18: (3 comments) https://gerrit.ovirt.org/#/c/39756/18/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterFeatureDaoTest.java File backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ClusterFeatureDaoTest.java: Line 55: assertNotNull("Failed to retrive supported additional features for the cluster", featuresSupportedInCluster); Line 56: assertTrue("Failed to retrive correct set of features for the given version and category", Line 57: featuresSupportedInCluster.size() == expectedFeatures.size()); Line 58: for (SupportedAdditionalClusterFeature supportedFeatures : featuresSupportedInCluster) { Line 59: assertTrue("Wrong feature returned from DB", > can be replaced with org.hamcrest.CoreMatchers.hasItem Done Line 60: expectedFeatures.contains(supportedFeatures.getFeature().getName())); Line 61: } Line 62: } Line 63: Line 77: dao.addSupportedClusterFeature(buildSupportedFeature(NEW_SUPPORTED_FEATURE_1, EXISTING_VDS_GROUP, true)); Line 78: Set<SupportedAdditionalClusterFeature> supportedFeatures = Line 79: dao.getSupportedFeaturesByClusterId(EXISTING_VDS_GROUP); Line 80: assertTrue("Failed to add the supported feature", Line 81: supportedFeatures.size() == previouslySupportedFeatures.size() + 1); > you can use org.hamcrest.Matchers.hasSize instead Done Line 82: } Line 83: Line 84: @Test Line 85: public void testAddAllSupportedClusterFeature() { Line 91: dao.addAllSupportedClusterFeature(newFeatures); Line 92: Set<SupportedAdditionalClusterFeature> supportedFeatures = Line 93: dao.getSupportedFeaturesByClusterId(EXISTING_VDS_GROUP); Line 94: assertTrue("Failed to add all the supported feature", Line 95: supportedFeatures.size() == previouslySupportedFeatures.size() + 2); > same Done Line 96: } Line 97: Line 98: @Test Line 99: public void testUpdateSupportedClusterFeature() { -- To view, visit https://gerrit.ovirt.org/39756 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icba02b189a169bc676e0c5f47f7aaf394f0b49a6 Gerrit-PatchSet: 18 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
