Maor Lipchuk has posted comments on this change. Change subject: core: consolidate register disk commands and queries ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/40730/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterDiskCommand.java: Line 43: } Line 44: Line 45: @Override Line 46: protected boolean canDoAction() { Line 47: // Currently this only supports importing images and does not work with luns. Please change comment accordingly (or just keep that this doesnt work with LUNS) Line 48: if (getParameters().getDiskImage().getDiskStorageType() != DiskStorageType.IMAGE && Line 49: getParameters().getDiskImage().getDiskStorageType() != DiskStorageType.CINDER) { Line 50: addCanDoActionMessageVariable("diskId", getParameters().getDiskImage().getId()); Line 51: addCanDoActionMessageVariable("storageType", getParameters().getDiskImage().getDiskStorageType()); Line 60: return false; Line 61: } Line 62: Line 63: if (!getStorageDomain().getStorageDomainType().isDataDomain() && Line 64: !(getStorageDomain().getStorageDomainType() == StorageDomainType.Volume)) { That means that every storage domain which is not Cinder could not register disks, am I wrong? Line 65: addCanDoActionMessageVariable("domainId", getParameters().getStorageDomainId()); Line 66: addCanDoActionMessageVariable("domainType", getStorageDomain().getStorageDomainType()); Line 67: addCanDoActionMessage(VdcBllMessages.ACTION_TYPE_FAILED_STORAGE_DOMAIN_TYPE_UNSUPPORTED); Line 68: return false; -- To view, visit https://gerrit.ovirt.org/40730 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc3558c635adb174af4fe89c63185268344d06aa Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
