Alona Kaplan has posted comments on this change. Change subject: engine: Add HostInterfaceValidator ......................................................................
Patch Set 15: (2 comments) https://gerrit.ovirt.org/#/c/34969/15/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/HostInterfaceValidator.java: Line 31: return ValidationResult.VALID; Line 32: } Line 33: Line 34: int slavesCount = 0; Line 35: for (VdsNetworkInterface nic : nics) { You've added the slaves property to Bond https://gerrit.ovirt.org/#/c/32909/17 Consider fill the slaves of the bond in the InterfaceDao (vdsNetworkInterfaceRowMapper.createInterface(..)), when creating the bond. So this code could be modified to- if (nic instanceOf Bond) { slaveCount = (Bond)nic.getSlaves().size(); } Line 36: if (StringUtils.equals(nic.getName(), iface.getBondName())) { Line 37: slavesCount++; Line 38: if (slavesCount == 2) { Line 39: break; https://gerrit.ovirt.org/#/c/34969/15/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 541: NETWORK_VLAN_IN_USE(ErrorType.CONFLICT), Line 542: NETWORK_ADDR_MANDATORY_IN_STATIC_IP(ErrorType.BAD_PARAMETERS), Line 543: NETWORK_MAC_ADDRESS_IN_USE(ErrorType.CONFLICT), Line 544: HOST_NETWORK_INTERFACE_NOT_EXIST(ErrorType.BAD_PARAMETERS), Line 545: NIC_NOT_EXISTS_ON_HOST(ErrorType.BAD_PARAMETERS), The ApplicationErrors files should be in this patch... I know you didn't want to modify Moti's patches and have done it in a later patch. Just mentioning:) Line 546: NETWORK_INTERFACE_NAME_ALREADY_IN_USE(ErrorType.CONFLICT), Line 547: NETWORK_INTERFACE_IN_USE_BY_VLAN(ErrorType.CONFLICT), Line 548: NETWORK_ALREADY_ATTACHED_TO_INTERFACE(ErrorType.CONFLICT), Line 549: NETWORK_INTERFACE_ALREADY_HAVE_NETWORK(ErrorType.CONFLICT), -- To view, visit https://gerrit.ovirt.org/34969 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iba235a70b0f42a75ca443b635c9eb51a4b2fee9a Gerrit-PatchSet: 15 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
