Roy Golan has posted comments on this change.

Change subject: webadmin: Added range values to QoS error message - revisited
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40854/4/frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
File 
frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties:

Line 1198: ACTION_TYPE_FAILED_QOS_STORAGE_POOL_NOT_CONSISTENT=Cannot ${action} 
${type}. Cannot change QoS data center.
Line 1199: 
Line 1200: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_VALUES=Cannot ${action} 
${type}. All three values are needed in order to define QoS on each network 
directions.
Line 1201: ACTION_TYPE_FAILED_NETWORK_QOS_NEGATIVE_VALUES=Cannot ${action} 
${type}. Negative values are not allowed.
Line 1202: ACTION_TYPE_FAILED_NETWORK_QOS_OUT_OF_RANGE_VALUES=Cannot ${action} 
${type}. Values are out of range.
need to remove that as it is unsable
Line 1203: ACTION_TYPE_FAILED_NETWORK_QOS_NAME_EXIST=Cannot ${action} ${type}. 
Duplicate QoS name in Data Center.
Line 1204: ACTION_TYPE_FAILED_NETWORK_QOS_MISSING_DATA=Cannot ${action} 
${type}. Invalid QoS.
Line 1205: ACTION_TYPE_FAILED_NETWORK_QOS_NOT_FOUND=Cannot ${action} ${type}. 
QoS entity not found.
Line 1206: ACTION_TYPE_FAILED_NETWORK_QOS_INVALID_DC_ID=Cannot ${action} 
${type}. Data Center does not contain the specific QoS entity.


-- 
To view, visit https://gerrit.ovirt.org/40854
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I05779f7c655dc7354af647e2c154efd19c66f28b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Tomer Saban <tsa...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to