Greg Sheremeta has posted comments on this change. Change subject: userportal, webadmin: added optional underlining to column headers ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40626/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/header/SafeHtmlHeader.java: Line 88: } Line 89: Line 90: @Override Line 91: public SafeHtml getValue() { Line 92: if (showUnderline) { > I would use the showUnderline in the setter instead of the getter. done Line 93: return templates.underlinedHeader(headerText); Line 94: } Line 95: return headerText; Line 96: } -- To view, visit https://gerrit.ovirt.org/40626 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2d1e2094410dae6a33897401aa83a2212ef645fd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Idan Shaby <ish...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
