Martin Peřina has posted comments on this change. Change subject: tools: extensions-tool: initial implementation logger ......................................................................
Patch Set 42: (1 comment) https://gerrit.ovirt.org/#/c/37886/42/backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java File backend/manager/extension-tool/src/main/java/org/ovirt/engine/exttool/core/ExtensionsToolExecutor.java: Line 139: logLevel != null ? Level.parse(logLevel) : Level.INFO Line 140: ); Line 141: } Line 142: Line 143: private static void setupLogger(Map<String, Object> args) throws IOException { Why not use JavaLoggingUtils here? Line 144: Logger logger = Logger.getLogger(""); Line 145: String logfile = (String)args.get("log-file"); Line 146: if(logfile != null) { Line 147: FileHandler fh = new FileHandler(logfile); -- To view, visit https://gerrit.ovirt.org/37886 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06113c5d56a49e58d557c851f9ff00b9a9ca409 Gerrit-PatchSet: 42 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondřej Macháček <machacek.on...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
