Francesco Romani has posted comments on this change. Change subject: WIP: core: bulk queries for VMConsoleProxyServlet #2 ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/40699/1/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmConsole.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmConsole.java: Line 3: import org.ovirt.engine.core.common.utils.ObjectUtils; Line 4: import org.ovirt.engine.core.compat.Guid; Line 5: Line 6: Line 7: public class VmConsole extends IVdcQueryable { > would it make sense to use ConsoleOptions entity? ConsoleOptions should fit the bill. Will rework the patch on top of that. Line 8: private static final long serialVersionUID = -2753306386502558044L; // FIXME Line 9: Line 10: private Guid vm_guid; Line 11: -- To view, visit https://gerrit.ovirt.org/40699 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I905b88a1bec0883a6826b913d81bc21520bf406f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
