Roy Golan has posted comments on this change. Change subject: core: always send numa node for vm ......................................................................
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/40481/2/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java: Line 1268: return; Line 1269: } Line 1270: Line 1271: // if user didn't set specific NUMA conf Line 1272: // create a default one with the first numa node of the host > do we really mind? if you don't care about numa (== you didn't configure a since that feature is going to be 3.6 only == RHEL 7.1 , is also means autonuma in kernel is working. so generally it should be fine to fit it in the first cell. as long as we are not pinned. Line 1273: if (vmNumaNodes.isEmpty()) { Line 1274: VmNumaNode vmNode = new VmNumaNode(); Line 1275: vmNode.setIndex(totalVdsNumaNodes.get(0).getIndex()); Line 1276: vmNode.setMemTotal(vm.getMemSizeMb()); -- To view, visit https://gerrit.ovirt.org/40481 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c7b0938bb0ab45883d637b594de61cd8695963a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
