Juan Hernandez has posted comments on this change. Change subject: restapi: Use description for discover FCP Storage in rsdl ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40776/2/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml File backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml: Line 1855: parameterType: Action Line 1856: signatures: Line 1857: - optionalArguments: {action.iscsi.address: 'xs:string', action.iscsi_target: 'xs:string'} Line 1858: description: Discover the iSCSI Storage Domains which are candidates to be imported to the setup Line 1859: - description: Discover the FCP Storage Domains which are candidates to be imported to the setup The dash before the second description means that there is a second signature, with no optional or mandatory arguments. Is that the intended meaning? If that is the case then I'd rather keep one signature, describe it as "Discover Storage Domains ..." (no reference to iSCSI or FCP). Line 1860: - name: /hosts/{host:id}/refreshcapabilities|rel=refreshcapabilities Line 1861: description: refresh the capabilities of the host Line 1862: request: Line 1863: body: -- To view, visit https://gerrit.ovirt.org/40776 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0657db41409bdebe936bb1c254a0912b32a7af18 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
