Alona Kaplan has posted comments on this change. Change subject: webadmin: Unified messages style and add update icon ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40631/6/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/host/SubTabHostGeneralInfoPresenter.java: Line 128: view.clearAlerts(); Line 129: Line 130: // Review the alerts and add those that are active: Line 131: if (model.getHasUpgradeAlert()) { Line 132: if (VdcActionUtils.canExecute(Arrays.asList(model.getEntity()), VDS.class, VdcActionType.UpgradeHost)) { 1. Please reorganize your patches so this patch will be after VdcActionUtils contain VdcActionUtils.UpgradeHost 2. Why not calling model.canUpgradeHost() instead of VdcActionUtils.canExecute(..)? Line 133: addTextAlert(view, messages.hostInSupportedStatusHasUpgradeAlert(), AlertType.UPDATE_AVAILABLE); Line 134: } else { Line 135: addTextAlert(view, messages.hostHasUpgradeAlert(), AlertType.UPDATE_AVAILABLE); Line 136: } -- To view, visit https://gerrit.ovirt.org/40631 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2223e928901cdbc40c4fb420851400e7ee1fb216 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
