Alona Kaplan has posted comments on this change. Change subject: webadmin: Add indication of updates for hosts ......................................................................
Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/40562/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostListModel.java: Line 1995: } Line 1996: }), Line 1997: vds.getId()); Line 1998: } else if (vds.getVdsType() == VDSType.VDS) { Line 1999: generalModel.setHasUpgradeAlert(vds.isUpdateAvailable()); Although seems it has no use, just to keep consistency, you should call generalModel.setHasAnyAlert(); Line 2000: } Line 2001: } Line 2002: Line 2003: @Override -- To view, visit https://gerrit.ovirt.org/40562 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia1dd135ffcd93788334c8f6237d26d89b78759a3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: hwbi <hwbi2...@gmail.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
