Dudi Maroshi has posted comments on this change. Change subject: monitor: implement NUMA aware KSM policy ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/40130/5/mom/Collectors/HostKSM.py File mom/Collectors/HostKSM.py: Line 43: self.open_files() Line 44: self.interval = properties['interval'] Line 45: self.pid = self._get_ksmd_pid() Line 46: self.last_jiff = self.get_ksmd_jiffies() Line 47: self.log = logging.getLogger('mom.Collectors.HostKSM') > you don't use this logger and its not related to the patch Done Line 48: Line 49: def __del__(self): Line 50: for datum in self.sysfs_keys: Line 51: if datum in self.files and self.files[datum] is not None: -- To view, visit https://gerrit.ovirt.org/40130 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I26caf0abe0a33a82b242549ba2ba4ad7f01ec925 Gerrit-PatchSet: 5 Gerrit-Project: mom Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
