Martin Peřina has posted comments on this change. Change subject: uutils: added new cli parser ......................................................................
Patch Set 12: (2 comments) https://gerrit.ovirt.org/#/c/40157/12/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/Argument.java: Line 15: private String metavar; Line 16: private boolean multivalue; Line 17: private String value; Line 18: Line 19: enum Type { > for these who understand getopt it is while you trying to take it to somewh Sorry, I don't care about getopt here (yes, I used it in the past in C, so I know what you are referring to).I want engine code to be readable and understandable Line 20: HAS_ARGUMENT, Line 21: OPTIONAL_ARGUMENT, Line 22: NO_ARGUMENT; Line 23: https://gerrit.ovirt.org/#/c/40157/12/backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java File backend/manager/modules/uutils/src/main/java/org/ovirt/engine/core/uutils/cli/parser/ArgumentsParser.java: Line 152: Line 153: /** Line 154: * Map which stores parsed converted arguments. Line 155: */ Line 156: private Map<String, Argument> arguments = new HashMap<>(); > it was good behavior in java-1.0 or java-2.0 where it was impossible. I don't see anything great on in-place initialization, it just make the the code less readable (even though Java compiler moves in-place initialization into constructor code in byte code). Line 157: Line 158: /** Line 159: * Set of mandatory arguments to check if user specified all of them. Line 160: */ -- To view, visit https://gerrit.ovirt.org/40157 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00042b669e19293641579582223e7ca40717132d Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Mooli Tayer <mta...@redhat.com> Gerrit-Reviewer: Ondra Machacek <omach...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
