Roy Golan has posted comments on this change. Change subject: core: introduce NumaNodePinning entity ......................................................................
Patch Set 10: (2 comments) https://gerrit.ovirt.org/#/c/38047/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodePinning.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/NumaNodePinning.java: Line 12: Line 13: /** Line 14: * id of the physical numa node Line 15: */ Line 16: private Guid physicalNodeId; > Reminder: we want to discard the GUID correct. a patch will follow Line 17: /** Line 18: * pinned or non pinned cell Line 19: */ Line 20: private Mode mode; Line 16: private Guid physicalNodeId; Line 17: /** Line 18: * pinned or non pinned cell Line 19: */ Line 20: private Mode mode; > if the mode is binary, and no other modes expeted in the futue. It is simpl I made that to prepare for 3rd option. like you mention it could be unknown or something similar. that will ensure the api stays the same. instead of moving onward from boolean to enum, we'll just add an enum member Line 21: /** Line 22: * the index of the related physical node Line 23: */ Line 24: private int index; -- To view, visit https://gerrit.ovirt.org/38047 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2ebd8f8e8aa87d92f9b01d70639940b0754bc96 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
