Moti Asayag has posted comments on this change. Change subject: core: Query GetVdsWithoutNetwork (WIP) ......................................................................
Patch Set 4: (3 inline comments) .................................................... File backend/manager/dbscripts/vds_sp.sql Line 870: AS $procedure$ Line 871: BEGIN Line 872: RETURN QUERY SELECT vds.* Line 873: FROM vds Line 874: INNER JOIN vds_groups you don't need to join vds_groups for the selection since vds_group_id already exists on vds table Line 875: ON vds.vds_group_id = vds_groups.vds_group_id Line 876: INNER JOIN network_cluster Line 877: ON vds_groups.vds_group_id = network_cluster.cluster_id Line 878: WHERE network_id = v_network_id Line 874: INNER JOIN vds_groups Line 875: ON vds.vds_group_id = vds_groups.vds_group_id Line 876: INNER JOIN network_cluster Line 877: ON vds_groups.vds_group_id = network_cluster.cluster_id Line 878: WHERE network_id = v_network_id s/network_id/network_cluster.network_id Line 879: AND NOT EXISTS ( Line 880: SELECT 1 Line 881: FROM vds_interface Line 882: INNER JOIN network Line 882: INNER JOIN network Line 883: ON network.name = vds_interface.network_name Line 884: INNER JOIN network_cluster Line 885: ON network.id = network_cluster.network_id Line 886: WHERE network_id = v_network_id s/network_id/network_cluster.network_id Line 887: AND vds.vds_group_id = network_cluster.cluster_id Line 888: AND vds_interface.vds_id = vds.vds_id); Line 889: END; $procedure$ Line 890: LANGUAGE plpgsql; -- To view, visit http://gerrit.ovirt.org/8528 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If458c00ddfe6ef3c0616683ceb4d397914de8456 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msa...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Muli Salem <msa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches