Simone Tiraboschi has posted comments on this change. Change subject: hosted-engine: hosted-engine client, with storage connection timeout ......................................................................
Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/40392/6/ovirt_hosted_engine_ha/lib/brokerlink.py File ovirt_hosted_engine_ha/lib/brokerlink.py: Line 248: """ Line 249: prevTimeout = self._socket.gettimeout() Line 250: self._socket.settimeout(20) Line 251: self._log.debug("Set socket timeout = %d", 20) Line 252: response = self._communicate(request) You are calling self._communicate with is calling util.socket_readline with is doing: sockfile = socket.makefile() but as far as I know makefile works only in blocking mode so you cannot really enforce that timeout. https://docs.python.org/2/library/socket.html#socket.socket.makefile Line 253: self._socket.settimeout(prevTimeout) Line 254: self._log.debug("Reset socket timeout = %s", str(prevTimeout)) Line 255: try: Line 256: status, message = response.split(" ", 1) -- To view, visit https://gerrit.ovirt.org/40392 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3be8d3cff0912c7a88ebb00145a17fa6dd2d892d Gerrit-PatchSet: 6 Gerrit-Project: ovirt-hosted-engine-ha Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stira...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
