Vered Volansky has posted comments on this change. Change subject: core: Add backend thresholds validation support ......................................................................
Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/40473/4/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties File backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties: Line 866: VALIDATION.VM.NUM_OF_MONITORS.EXCEEDED=VM exceeded the number of allowed monitors Line 867: VALIDATION.STORAGE_DOMAIN.NAME.INVALID=Storage Domain name must be formed of "a-z0-9A-Z" or "-_" Line 868: VALIDATION.STORAGE_DOMAIN.DESCRIPTION.INVALID=Storage Domain description must be formed of "a-z0-9A-Z" or "-_" Line 869: VALIDATION.STORAGE_DOMAIN.DESCRIPTION.MAX=Storage Domain description must not exceed 4000 characters Line 870: VALIDATION.STORAGE_DOMAIN.WARNING_LOW_SPACE_INDICATOR.RANGE=Storage Domain's warning_low_space_indicator must be a number between 0 and 100. > perhaps "must be an integer" instead of "must be a number"? 12.345 is also Done Line 871: VALIDATION.STORAGE_DOMAIN.CRITICAL_SPACE_ACTION_BLOCKER.RANGE=Storage Domain's critical_space_action_blocker must be between a number 0 and 100. Line 872: VALIDATION.VM_TEMPLATE.NAME.MAX=VM Template name must not exceed 40 characters Line 873: VALIDATION.DISK_INTERFACE.NOT_NULL=Interface is required Line 874: VALIDATION.VOLUME_TYPE.NOT_NULL=Volume type is required -- To view, visit https://gerrit.ovirt.org/40473 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09fe2b127386e273afa2ca0b04324f923a863c0d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches