Yevgeny Zaspitsky has posted comments on this change. Change subject: core: return backend instances with CDI instead JNDI ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/40641/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java: Line 104: @Inject Line 105: private DbFacade dbFacade; Line 106: Line 107: public static BackendInternal getInstance() { Line 108: return Injector.get(BackendInternal.class); > why not just "this" cannot be used as that's a static method. On the other hand, that could've done before going CDI. I guessguess that gives us some decoupling. If we like using CDI for obtaining the class instance, I'd prefer using @Inject in the client classes, rather than the static way. Line 109: } Line 110: Line 111: private void initHandlers() { Line 112: mTagsHandler = HandlersFactory.createTagsHandler(); -- To view, visit https://gerrit.ovirt.org/40641 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3710d057c7feffe3c14f9b8d582bbc1c70461fa8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
