Alon Bar-Lev has posted comments on this change. Change subject: aaa: Modify welcome screen to show user name and options as menu ......................................................................
Patch Set 4: (2 comments) all aaa changes can be squashed into the previous patch, the config can be squashed except error to the sso patch, leave only welcome changes. https://gerrit.ovirt.org/#/c/40672/4/backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java File backend/manager/modules/aaa/src/main/java/org/ovirt/engine/core/aaa/servlet/SSOPostLoginServlet.java: Line 69: welcomeUrl.append(request.getServerName()); Line 70: welcomeUrl.append(":"); Line 71: welcomeUrl.append(request.getServerPort()); Line 72: welcomeUrl.append(EngineLocalConfig.getInstance().getProperty("SSO_WELCOME_URL")); Line 73: welcomeUrl.append("/?"); please use String.format, much easier to read. we should probably have some helper to produce urls... Line 74: String switchUserUrl = EngineLocalConfig.getInstance().getProperty("SSO_SWITCH_USER_URL") + "?"; Line 75: request.getSession(true).setAttribute("sso_user", username); Line 76: request.getSession(true).setAttribute("sso_switch_user_url", String.format("%s?post_action_url=%s&version=%s&invalidate=1&external=0", switchUserUrl, response.encodeURL(welcomeUrl.toString()), "0")); Line 77: String msg = String.format("The user %s is not authorized to perform login", username); https://gerrit.ovirt.org/#/c/40672/4/packaging/services/ovirt-engine/ovirt-engine.conf.in File packaging/services/ovirt-engine/ovirt-engine.conf.in: squash? Line 1: # Line 2: # These are the default values for the local configuration. Line 3: # Line 4: # Please don't edit this file as it won't be preserverd when updating the -- To view, visit https://gerrit.ovirt.org/40672 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0227778d53f4c63867aa2887580539efab8fa7c8 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
