Omer Frenkel has posted comments on this change. Change subject: core: commited counted was missing vms ......................................................................
Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/40611/6/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VmsListFetcher.java: Line 80: VM vm = new VM( Line 81: dbVms.get(vmInternalData.getVmDynamic().getId()).getStaticData(), Line 82: vmInternalData.getVmDynamic(), Line 83: vmInternalData.getVmStatistics()); Line 84: vm.setDynamicData(vmInternalData.getVmDynamic()); why setting dynamic again? Line 85: vms.add(vm); Line 86: } Line 87: } Line 88: vdsManager.setLastVmsList(vms); -- To view, visit https://gerrit.ovirt.org/40611 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id94addb1a387b5aec284325c4cc0a17ad1cab9fb Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
