Dudi Maroshi has posted comments on this change. Change subject: engien: Add KSM policy to NUMA hosts ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/39864/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java: Line 145: Line 146: setSucceeded(true); Line 147: } Line 148: Line 149: private void publishMomPolicyOnKsmPolicyChange() { > I want this out of the responsibility of the command. Done Line 150: // collect all Active hosts into a callable list Line 151: List<Callable<VDSReturnValue>> callables = new LinkedList<>(); Line 152: final VDSGroup cluster = getVdsGroup(); Line 153: for (final VDS vds : allForVdsGroup) { Line 166: } Line 167: Line 168: private VDSReturnValue runUpdateMomPolicy(final VDSGroup cluster, final VDS vds) { Line 169: VDSReturnValue returnValue = new VDSReturnValue(); Line 170: if (cluster.getCompatibilityVersion().compareTo(Version.v3_5) >= 0) { > should we also update when the compat version is also 3.4? Done Line 171: try { Line 172: returnValue = runVdsCommand(VDSCommandType.SetMOMPolicyParameters, Line 173: new MomPolicyVDSParameters(vds, Line 174: cluster.isEnableBallooning(), -- To view, visit https://gerrit.ovirt.org/39864 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9efa046547fb3732f0fb059092e5f444d72d589c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Dudi Maroshi <d...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
