[Engine-patches] Change in ovirt-engine[master]: core: fix external events permissions check

[emesika]

Eli Mesika has uploaded a new change for review.

Change subject: core: fix external events permissions check
......................................................................

core: fix external events permissions check

Current implementation missing handling of Host permissions check.
Adding a check for host permissions

Change-Id: I627fa765f740435bbee17b0071528464f46d9902
Signed-off-by: emesika <emes...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/51/40651/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
index a3a357e..b0128fd3 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExternalEventCommandBase.java
@@ -50,6 +50,10 @@
             permissionList.add(new PermissionSubject(new 
Guid(event.getVmTemplateId().toString()),
                 VdcObjectType.VmTemplate, ActionGroup.INJECT_EXTERNAL_EVENTS));
         }
+        if (event.getVdsId() != null) {
+            permissionList.add(new PermissionSubject(new 
Guid(event.getVdsId().toString()),
+                    VdcObjectType.VDS, ActionGroup.INJECT_EXTERNAL_EVENTS));
+        }
         if (permissionList.isEmpty()) { // Global Event
             permissionList.add(new 
PermissionSubject(MultiLevelAdministrationHandler.SYSTEM_OBJECT_ID,
                 VdcObjectType.System,


-- 
To view, visit https://gerrit.ovirt.org/40651
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I627fa765f740435bbee17b0071528464f46d9902
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika <emes...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches