David Caro has posted comments on this change.

Change subject: uses yum-deprecated where available
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40643/1/jobs/confs/shell-scripts/mock_install.sh
File jobs/confs/shell-scripts/mock_install.sh:

Line 114: $my_mock \
Line 115:     --no-clean \
Line 116:     --shell <<EOF
Line 117: yum_command=`which yum-deprecated` || yum_command=`which yum`
Line 118: $yum_command install -y /tmp/*rpm
> 08:05:47 ]0;<mock-chroot><mock-chroot>sh-4.3# yum_command= || yum_command
here the issue seems to be the extra expansion at which the code is exposed to, 
try:

 yum_command=\$(which yum-deprecated) \
 || yum_command=\$(which yum)
 \$yum_command install -y /tmp/*rpm

with the escapes it should skip the first expansion (done outside mock)


-- 
To view, visit https://gerrit.ovirt.org/40643
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64ad89d1c8202f3da00763cc93fca6178864899f
Gerrit-PatchSet: 1
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: David Caro <dcaro...@redhat.com>
Gerrit-Reviewer: Eyal Edri <ee...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman <sshna...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to