Vojtech Szocs has posted comments on this change. Change subject: userportal, webadmin: show tooltips on cropped input boxes ......................................................................
Patch Set 3: (2 comments) In general looks OK, posted some comments, but I see that you will probably modify this patch (resize handler stuff). https://gerrit.ovirt.org/#/c/39121/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementUtils.java: Line 47: * Line 48: * @param element the input[type=text] we're checking Line 49: * @return if the text doesn't fit in the input box Line 50: */ Line 51: public static native boolean detectOverflowUsingPixelWidth(Element element) > long live jQuery! Nice trick! Line 52: /*-{ Line 53: var $element = $wnd.jQuery(element); Line 54: var $span = $wnd.jQuery('<span>' + $element.val() + '</span>'); Line 55: $span.css({ https://gerrit.ovirt.org/#/c/39121/3/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/label/TextBoxLabelBase.java: Line 104: } Line 105: } Line 106: }, MouseDownEvent.getType()); Line 107: Line 108: Window.addResizeHandler(new ResizeHandler() { > this doesn't handle all resizes possible. When a GWT widget (its corresponding DOM element) gets detached from DOM, any handlers should be removed, too, I think. If we want to use Window.addResizeHandler, maybe also override onUnload() to remove the resize handler (via HandlerRegistration.removeHandler). Line 109: @Override Line 110: public void onResize(ResizeEvent event) { Line 111: setTooltip(SafeHtmlUtils.fromString(getText())); Line 112: } -- To view, visit https://gerrit.ovirt.org/39121 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6713b4aa624948477e295db0a95f24fbf251ca4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
