Mike Kolesnik has posted comments on this change.
Change subject: core: Query GetVdsGroupsByNetworkId (WIP)
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
Line 327: */
Line 328: @Test
Line 329: public void testGetAllForNetwork() {
Line 330: List<VDSGroup> result =
dao.getAllForNetwork(FixturesTool.NETWORK_ENGINE_2);
Line 331: assertEquals(existingVdsGroups, result);
This test might fail if the returned list differs in order than the expected
list but contains the same elements.
I would use a loop over the expected results to see if they are contained
somewhere in the returned collection.
Line 332: }
Line 333:
Line 334: /**
Line 335: * Ensures that no vds groups are fetched.
--
To view, visit http://gerrit.ovirt.org/8426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5602c19e731cf0c3fe1377a574eac9ac42d351b6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
