Alona Kaplan has posted comments on this change. Change subject: webadmin: fluent UiAction ......................................................................
Patch Set 45: (3 comments) https://gerrit.ovirt.org/#/c/36848/45/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/Frontend.java: Line 1230: /** Line 1231: * Translate and show popup for the actions errors Line 1232: */ Line 1233: public void runMultipleActionsFailed(Map<VdcActionType, List<VdcReturnValueBase>> failedActionsMap, MessageFormatter messageFormatter) { Line 1234: Collection<VdcReturnValueBase> failedResults = new LinkedList<>(); > Really no need to make this a LinkedList, ArrayList works just as well. In Done Line 1235: for (List<VdcReturnValueBase> vdcActionTypeResults : failedActionsMap.values()) { Line 1236: failedResults.addAll(vdcActionTypeResults); Line 1237: } Line 1238: translateErrors(failedResults); https://gerrit.ovirt.org/#/c/36848/45/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/IFrontendEventsHandler.java: Line 26: Line 27: void publicConnectionClosed(Exception ex); Line 28: Line 29: public static interface MessageFormatter { Line 30: public String format(String message); > To add to Vojtechs comment, no need for public in interfaces period as they Done Line 31: } https://gerrit.ovirt.org/#/c/36848/45/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiVdcMultipleAction.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/action/UiVdcMultipleAction.java: Line 33: */ Line 34: public class UiVdcMultipleAction extends UiAction { Line 35: Line 36: private VdcActionType actionType; Line 37: private Collection<? extends VdcActionParametersBase> parametersList; > Since this is a collection, can we call it parameterCollection, or change t Done Line 38: boolean waitForResult; Line 39: boolean runNextInCaseOfError; Line 40: Line 41: /** -- To view, visit https://gerrit.ovirt.org/36848 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I262282d00bbb16a65f36a2463d3ffe8dbf6594c6 Gerrit-PatchSet: 45 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Yevgeny Zaspitsky <yzasp...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
