Michael Pasternak has posted comments on this change.

Change subject: restapi: RFE: add smartcard support
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

please add this property to the mapper's tests.

....................................................
File 
backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
Line 1824:       <xs:element name="port" type="xs:unsignedShort" minOccurs="0" 
maxOccurs="1"/>
Line 1825:       <xs:element name="secure_port" type="xs:unsignedShort" 
minOccurs="0" maxOccurs="1"/>
Line 1826:       <xs:element name="monitors" type="xs:int" minOccurs="0" 
maxOccurs="1"/>
Line 1827:       <xs:element name="allow_override" type="xs:boolean" 
minOccurs="0" maxOccurs="1"/>
Line 1828:       <xs:element name="smartcardEnabled" type="xs:boolean" 
minOccurs="0" maxOccurs="1"/>
naming convention in api is x_y
Line 1829:     </xs:sequence>
Line 1830:   </xs:complexType>
Line 1831: 
Line 1832:   <xs:complexType name="Ticket">


--
To view, visit http://gerrit.ovirt.org/8512
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibddf2c606e80cd951fc5d82bc0413d96610f451a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to