Moti Asayag has posted comments on this change. Change subject: engine: Extends vds_dynamic with updates_available ......................................................................
Patch Set 3: (2 comments) https://gerrit.ovirt.org/#/c/39862/3/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsDynamicDAODbFacadeImpl.java: > worth adding a test that updates only the new field and check that it was O sure Line 1: package org.ovirt.engine.core.dao; Line 2: Line 3: import java.sql.ResultSet; Line 4: import java.sql.SQLException; https://gerrit.ovirt.org/#/c/39862/3/packaging/dbscripts/vds_sp.sql File packaging/dbscripts/vds_sp.sql: Line 364: Line 365: RETURN; Line 366: END; $procedure$ Line 367: LANGUAGE plpgsql; Line 368: > Don't we want to enable updating this field alone in the same manner we are since this is expected to be called once a day - i'm not sure it worth the effort. Line 369: Line 370: Line 371: Line 372: -- To view, visit https://gerrit.ovirt.org/39862 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c788b17cb58791fe540b7130965a210557e68a5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
