Gilad Chaplik has posted comments on this change. Change subject: webadmin: sr-iov validation of profile in vnic dialog ......................................................................
Patch Set 29: (1 comment) minor comment, can be addressed in a later patch. https://gerrit.ovirt.org/#/c/36101/29/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/VnicProfileValidation.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/VnicProfileValidation.java: Line 22: Line 23: boolean isPassthroughSupported = Line 24: (Boolean) AsyncDataProvider.getInstance() Line 25: .getConfigValuePreConverted(ConfigurationValues.NetworkSriovSupported, Line 26: clusterCompatabilityVersion); I'd consider hiding the property if it's not supported. Line 27: Line 28: if (profile.isPassthrough() && !isPassthroughSupported) { Line 29: return ValidationResult.fail(ConstantsManager.getInstance() Line 30: .getMessages() -- To view, visit https://gerrit.ovirt.org/36101 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d0d834d0bab6e2490279fef8f1140edcdfdcb1 Gerrit-PatchSet: 29 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
