Arik Hadas has posted comments on this change. Change subject: webadmin: introduce ImportVmModel ......................................................................
Patch Set 41: (2 comments) https://gerrit.ovirt.org/#/c/36673/41/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java: Line 99: } Line 100: })); Line 101: } Line 102: Line 103: ImportVmModel(final ClusterListModel<Void> cluster, final QuotaListModel clusterQuota) { > constructor in the middle of the class? Please move up. Done Line 104: this.cluster = cluster; Line 105: this.clusterQuota = clusterQuota; Line 106: setCpuProfiles(new ListModel<CpuProfile>()); Line 107: } Line 129: private void setCpuProfiles(ListModel<CpuProfile> value) { Line 130: cpuProfiles = value; Line 131: } Line 132: Line 133: // TODO: should the above be a CpuProfileListModel? > ok, this comment does not help anyone anymore - please delete it Done Line 134: // private final CpuProfileListModel cpuProfiles; Line 135: // Line 136: // public CpuProfileListModel getCpuProfiles() { Line 137: // return cpuProfiles; -- To view, visit https://gerrit.ovirt.org/36673 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I69f79fd0a5433a7af3212ecded8affa23c5247fb Gerrit-PatchSet: 41 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
