Tomas Jelinek has posted comments on this change. Change subject: userportal: Vm Icons - userportal part ......................................................................
Patch Set 7: (1 comment) one very small comment - otherwise nice patch! https://gerrit.ovirt.org/#/c/40320/7/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/IconUtils.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/IconUtils.java: Line 43: final List<Guid> iconIdsToPrefetch = extractSmallIconIds(vmsAndPoolRepresentants, smallIcons, largeIcons); Line 44: IconCache.getInstance().getOrFetchIcons(iconIdsToPrefetch, callback); Line 45: } Line 46: Line 47: private static List<Guid> extractSmallIconIds(Collection<VM> vms, boolean smallIcons, boolean largeIcons) { maybe just call it "extractIconIds(..." since it does both small and large Line 48: final List<Guid> result = new ArrayList<>(); Line 49: for (VM vm: vms) { Line 50: if (smallIcons) { Line 51: result.add(vm.getStaticData().getSmallIconId()); -- To view, visit https://gerrit.ovirt.org/40320 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5d1b2e313aac9640950919e4c4cb41eb247913a3 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jnied...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
