Alona Kaplan has posted comments on this change. Change subject: core: Introduce BusinessEntityMap ......................................................................
Patch Set 23: (3 comments) https://gerrit.ovirt.org/#/c/33329/23/backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMapTest.java File backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/businessentities/BusinessEntityMapTest.java: Line 14: public class BusinessEntityMapTest { Line 15: Line 16: @Test Line 17: public void testGetDontFailWithNullParameter() throws Exception { Line 18: new BusinessEntityMap<TestItem>(null); Where is the get? Line 19: } Line 20: Line 21: @Test(expected = IllegalArgumentException.class) Line 22: public void testCreatingBusinessEntityMapWithDuplicatesAmongIds() throws Exception { Line 50: } Line 51: Line 52: @Test Line 53: public void testGetByIdReturnsItemOfThatId() throws Exception { Line 54: Guid sameId = Guid.newGuid(); Why not itemId? Line 55: TestItem first = new TestItem(sameId, null); Line 56: BusinessEntityMap<TestItem> map = new BusinessEntityMap<>(Arrays.asList(first)); Line 57: Line 58: assertThat(map.get(sameId), is(first)); Line 51: Line 52: @Test Line 53: public void testGetByIdReturnsItemOfThatId() throws Exception { Line 54: Guid sameId = Guid.newGuid(); Line 55: TestItem first = new TestItem(sameId, null); Why not item? Line 56: BusinessEntityMap<TestItem> map = new BusinessEntityMap<>(Arrays.asList(first)); Line 57: Line 58: assertThat(map.get(sameId), is(first)); Line 59: } -- To view, visit https://gerrit.ovirt.org/33329 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4540f813f8a787a38ba3e692b6ddd3fcc6be536a Gerrit-PatchSet: 23 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Alona Kaplan <alkap...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Mucha <mmu...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <wallaroo1...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
